Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[9.0](backport #6948) Use newer multiarch support for DRA packaging in ARM #6951

Merged
merged 1 commit into from
Feb 20, 2025

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Feb 20, 2025

What does this PR do?

  • switch to ubuntu 22.04 ARM for the ARM part of the DRA packaging
  • enable multi arch builds avoid the exec format errors when attempting to build arm64 inside arm64 workers

Why is it important?

After the recent upgrade to go 1.23.6 we are noticing failures like

>> buildGoDaemon: Building for linux/arm64
Unable to find image 'docker.elastic.co/beats-dev/golang-crossbuild:1.23.6-arm' locally
1.23.6-arm: Pulling from beats-dev/golang-crossbuild
d8ccec8a513f: Pull complete
Digest: sha256:4e859ff74164fe8ebc675f93691083aecf7cd13b6fb4f78723a9e8ddad8b4692
Status: Downloaded newer image for docker.elastic.co/beats-dev/golang-crossbuild:1.23.6-arm
exec /crossbuild: exec format error

in the packaging ARM step

How to test this PR locally

Tested via https://buildkite.com/elastic/elastic-agent-package/builds/4332#0195241f-2d2a-495c-99d1-4c45dd39ff72

Related issues

Relates to elastic/golang-crossbuild#507


This is an automatic backport of pull request #6948 done by [Mergify](https://mergify.com).

This commit fixes a recent problem where the packaging ARM step
started failing after upgrading go from 1.22 to 1.23.

It does so by:
- switching to Ubuntu 22.04 ARM for the ARM part of the DRA packaging
- enabling multi arch builds using a similar approach to elastic/golang-crossbuild#507

(cherry picked from commit 93cfb49)
@mergify mergify bot requested a review from a team as a code owner February 20, 2025 17:05
@mergify mergify bot added the backport label Feb 20, 2025
Copy link
Contributor

@dliappis dliappis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as its a clean backport

@dliappis dliappis enabled auto-merge (squash) February 20, 2025 17:15
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@dliappis dliappis merged commit 822c69f into 9.0 Feb 20, 2025
12 checks passed
@dliappis dliappis deleted the mergify/bp/9.0/pr-6948 branch February 20, 2025 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant